Missing term in calculation of TOTAL_VALUES. (anuraghazra#2116)

* fix: added missing term in calculation of TOTAL_VALUES. * fix: fix rank test * refactor: update code formatting * refactor: update code formatting Co-authored-by: rickstaa <rick.staa@outlook.com>
devantler · May 1, 2023 · 9497cd7 · 9497cd7
1 parent 653de7c
commit 9497cd7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/calculateRank.js b/src/calculateRank.js
@@ -70,7 +70,11 @@ function calculateRank({
   const RANK_B_VALUE = 100;
 
   const TOTAL_VALUES =
-    RANK_S_VALUE + RANK_A2_VALUE + RANK_A3_VALUE + RANK_B_VALUE;
+    RANK_S_VALUE +
+    RANK_DOUBLE_A_VALUE +
+    RANK_A2_VALUE +
+    RANK_A3_VALUE +
+    RANK_B_VALUE;
 
   // prettier-ignore
   const score = (

diff --git a/tests/calculateRank.test.js b/tests/calculateRank.test.js
@@ -13,6 +13,6 @@ describe("Test calculateRank", () => {
         prs: 300,
         issues: 200,
       }),
-    ).toStrictEqual({ level: "A+", score: 49.16605417270399 });
+    ).toStrictEqual({ level: "A+", score: 49.25629684876535 });
   });
 });
diff --git a/tests/e2e/e2e.test.js b/tests/e2e/e2e.test.js
@@ -22,7 +22,7 @@ const STATS_DATA = {
   contributedTo: 2,
   rank: {
     level: "A+",
-    score: 51.01013099671447,
+    score: 50.900829325065935,
   },
 };