Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing support for .hbs Handlebars files #50

Closed
nikouu opened this issue Oct 7, 2021 · 3 comments
Closed

Missing support for .hbs Handlebars files #50

nikouu opened this issue Oct 7, 2021 · 3 comments

Comments

@nikouu
Copy link
Contributor

nikouu commented Oct 7, 2021

Currently there is no .hbs file support for the Handlebars templating language. https://handlebarsjs.com/

Expected Behavior

A moustache icon with an orange colouring for .hbs files.
image

Current Behavior

.hbs files have no configuration and are shown using the default icon and colour.
image

Possible Solution

The default Seti icon set in VS Code looks nice and would be ideal. The following is an example screenshot from VS Code:
image

Context

I use the Handlebars and it would be great to see .hbs files styled too.

Your Environment

  • Module version used: 0.5.2
  • Operating System and PowerShell version: Windows 10 and Powershell 7.1.4
@nikouu
Copy link
Contributor Author

nikouu commented Oct 7, 2021 •
edited

I have a fork ready to go https://github.com/nikouu/Terminal-Icons/tree/handlebars with the before and after looking like:
image

main...nikouu:handlebars

@devblackops
Copy link
Owner

@nikouu This looks good. Can you submit a PR?

@nikouu nikouu mentioned this issue Nov 9, 2021
Merged
9 tasks
@devblackops
Copy link
Owner

Thanks @nikouu. v0.7.0 has been published with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikouu @devblackops