Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Handlebars (.hbs) Support #53

Merged
merged 2 commits into from Nov 11, 2021
Merged

Adding Handlebars (.hbs) Support #53

merged 2 commits into from Nov 11, 2021

Conversation

nikouu
Copy link
Contributor

@nikouu nikouu commented Nov 9, 2021

Adding .hbs file support for the Handlebars templating language. https://handlebarsjs.com/

Description

  1. Trimmed excess whitespace
  2. Added .hbs support. Work copied from the default Seti icon set in VS Code.

Related Issue

#50

Motivation and Context

I use the Handlebars and it would be great to see .hbs files styled too.

How Has This Been Tested?

  1. Ran all tests by running build.ps1
    image
  2. Ran Import-Module .\Terminal-Icons.psm1 found in the Output folder from the build in step 1
  3. Saw expected behaviour of .hbs files being styled
    image

Screenshots (if appropriate):

The before and after:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nikouu
Trimmed whitespace
dcaf177
@nikouu
Added Handlebars
f748d2a 
Added support for .hbs files based on the icon and color from seti-ui
@devblackops devblackops self-assigned this Nov 11, 2021
@devblackops devblackops added the enhancement New feature or request label Nov 11, 2021
@devblackops devblackops merged commit a8327c2 into devblackops:main Nov 11, 2021
@nikouu
Copy link
Contributor Author

nikouu commented Nov 11, 2021

Thanks @devblackops! 😄

@nikouu nikouu deleted the handlebars branch November 11, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@devblackops devblackops

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikouu @devblackops