Make the install script verify the checksum automatically #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pior
commented
May 28, 2018
| @@ -1,13 +1,12 @@ | |||
| #!/usr/bin/env bash | |||
| set -eu | |||
|
|
|||
| VERSION="v0.3.0" | |||
| VERSION="v0.4.0" | |||
There was a problem hiding this comment.
This version doesn't exist but we need the path fix from #103, which will only be available in the next release.
install.sh
Outdated
|
|
||
| [[ -e "${TMPFILE}" ]] && unlink "${TMPFILE}" | ||
| rm -rf "${TMPDIR}" |
There was a problem hiding this comment.
Should we just leave the tmpdir to avoid doing a rm -rf ?
There was a problem hiding this comment.
I think that's quite common to keep those tempdir and anyway something should clean this up at one point automatically no?
There was a problem hiding this comment.
i don't like using -rf in a script
mlhamel
approved these changes
May 30, 2018
pior
changed the title
pior
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The install script should not ask the user to compare the checksums, it should let
shasumdo that.How
Download the checksum file at the right place and run
shasum -c, which would warn and fail the whole script in case of a mismatch.BLOCKED until the next release because we need to the new shasum files introduced by #103