Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Default link for open command #109

Merged
merged 8 commits into from Jun 8, 2018
Merged

[FEATURE] Default link for open command #109

merged 8 commits into from Jun 8, 2018

Conversation

pior
Copy link
Member

@pior pior commented Jun 3, 2018

Why

When only one link is specified in dev.yml, the open command should open it (follow the behavior of Dev).

How

  • Refactor code by moving code to the helpers package
  • Add tests

Notes:

  • Introduce a subpackage in helpers package
  • Introduce a test package to help re-use code in tests

Resolves #66

@pior pior requested a review from mlhamel as a code owner June 3, 2018 17:13
@pior pior changed the title WIP - [FEATURE] Default link for open command [FEATURE] Default link for open command Jun 4, 2018
@pior
Copy link
Member Author

pior commented Jun 8, 2018

I will go ahead and merge this PR, but feedbacks are still welcome!

@pior pior merged commit c05c4e5 into master Jun 8, 2018
@pior pior deleted the open-default-link branch June 18, 2018 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant