Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Pytest and Pexpect for the integration tests #126

Merged
merged 22 commits into from Jun 21, 2018
Merged

Use Pytest and Pexpect for the integration tests #126

merged 22 commits into from Jun 21, 2018

Conversation

pior
Copy link
Member

@pior pior commented Jun 11, 2018 •
edited

Why

The integration tests with ShUnit2 are not scalable, testing tooling is hard to build and the execution context is not fully controlled.

How

This new integration test suite is using:

  • Pytest, for the test runner and testing helpers
  • Pexpect to control an isolated shell

Notes:

  • the ZSH are passing locally but failing in CI, we'll disable them in CI (Bash tests are passing)

@pior pior requested a review from mlhamel as a code owner June 11, 2018 02:52
@pior pior force-pushed the pytest branch 4 times, most recently from 9102598 to 8942deb Compare June 14, 2018 00:12
@pior pior mentioned this pull request Jun 14, 2018
Open
15 tasks
@pior pior changed the title WIP - Use Pytest and Pexpect for the integration tests Use Pytest and Pexpect for the integration tests Jun 21, 2018
@pior pior merged commit bcf9ee2 into master Jun 21, 2018
@pior pior deleted the pytest branch June 21, 2018 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlhamel mlhamel Awaiting requested review from mlhamel mlhamel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pior