Add --list flag to open command #129
Conversation
pkg/cmd/open.go
Outdated
| } | ||
|
|
||
| func init() { | ||
| openCmd.Flags().Bool("list", false, "List available project's URLs") |
There was a problem hiding this comment.
I think this is the wrong option type
manumilou
force-pushed
the
cmd-open-add-list-option
branch
from
662017f
to
e41530a
Compare
pkg/helpers/open/open.go
Outdated
| @@ -51,3 +51,10 @@ func FindLink(proj *project.Project, linkName string) (url string, err error) { | |||
|
|
|||
| return | |||
| } | |||
|
|
|||
| func PrintLinks(proj *project.Project) { | |||
| var url, title string | |||
There was a problem hiding this comment.
can we get rid of this declaration?
pkg/helpers/open/open.go
Outdated
| func PrintLinks(proj *project.Project) { | ||
| var url, title string | ||
| for title, url = range proj.Manifest.Open { | ||
| fmt.Println(title, url) |
There was a problem hiding this comment.
Better formatting ?
pkg/cmd/open.go
Outdated
| @@ -1,17 +1,23 @@ | |||
| package cmd | |||
|
|
|||
| import ( | |||
| "os" | |||
manumilou
force-pushed
the
cmd-open-add-list-option
branch
from
0ae2926
to
aceb775
Compare
| if GetFlagBool(cmd, "list") { | ||
| err = open.PrintLinks(proj) | ||
| checkError(err) | ||
| os.Exit(0) |
There was a problem hiding this comment.
checkError already exits with 1 (which may not be optimal in this case, but we can live with that I think)
There was a problem hiding this comment.
If there is no error though, we need to exit properly. Otherwise, we'll fail on the next error Error: which link should I open?.
pkg/helpers/open/open.go
Outdated
| } | ||
| var url, title string | ||
| for title, url = range proj.Manifest.Open { | ||
| fmt.Println(title, url) |
There was a problem hiding this comment.
We could use \t as a limited attempt to align the columns.
manumilou
force-pushed
the
cmd-open-add-list-option
branch
from
28633e2
to
3c947af
Compare
manumilou
changed the title
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
This function is not really in the scope of the open helper.
It's fine to keep it here for now, but the fuzzy search adds some more code related to links, I think we should create a links helper for that.
There was a problem hiding this comment.
I think you're right. Knowing how to print a link is not really the concern of the open helper.
There was a problem hiding this comment.
Incremental changes! Let's ship that and keep it in mind!
manumilou
force-pushed
the
cmd-open-add-list-option
branch
from
3c947af
to
17516e3
Compare
manumilou
force-pushed
the
cmd-open-add-list-option
branch
from
17516e3
to
8774738
Compare
Why
Add the
--listflag support for the open command.The
--listcommand modifier lists in the standard output the entries found in theopensection ofdev.ymlconfiguration file.Resolves #111
How
Using Cobra local Flags primitive.