Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds dev command for building #132

Merged
merged 1 commit into from Jun 21, 2018
Merged

Adds dev command for building #132

merged 1 commit into from Jun 21, 2018

Conversation

mlhamel
Copy link
Collaborator

@mlhamel mlhamel commented Jun 20, 2018

Why

It's so much more convenient to have a command that build devbuddy directly from dev.yml

How

Just adding it

@mlhamel mlhamel requested a review from pior as a code owner June 20, 2018 03:03
pior
pior approved these changes Jun 21, 2018
View reviewed changes
Copy link
Member

@pior pior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Just curious: what's the use case?

@mlhamel
Copy link
Collaborator Author

mlhamel commented Jun 21, 2018

Mostly for me the final step before pushing a PR is to compile devbuddy

Also if we have a script it kind of make to also have shortcut.

@mlhamel mlhamel merged commit 169f623 into master Jun 21, 2018
@mlhamel mlhamel deleted the adds-build-all-cmd branch June 21, 2018 02:32
@pior
Copy link
Member

pior commented Jun 21, 2018

@mlhamel isn't bud install-dev enough for this use-case?

@mlhamel mlhamel restored the adds-build-all-cmd branch October 8, 2018 19:23
@mlhamel mlhamel deleted the adds-build-all-cmd branch October 12, 2018 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pior pior pior approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlhamel @pior