Make the feature a taskAction property (was a task property) #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlhamel
reviewed
Jan 18, 2019
| featureSet = featureSet.With(task.Feature) | ||
| for _, action := range task.Actions { | ||
| if action.Feature() != nil { | ||
| featureSet = featureSet.With(*action.Feature()) |
There was a problem hiding this comment.
don't you want to break if you find a matching case ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
nodetask is providing an env-feature, likepythonorgo.The difference is that this task also includes a taskAction (
npm) that should run once the env feature is activated.It's an issue since the env-feature is activated after the task is complete.
How