Run the custom commands with the envvars from manifest #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pior
force-pushed
the
fix-custom-command-env
branch
4 times, most recently
from
9de7783
to
70130d0
Compare
pior
force-pushed
the
fix-custom-command-env
branch
from
70130d0
to
b5dd478
Compare
pior
force-pushed
the
fix-custom-command-env
branch
2 times, most recently
from
448df8a
to
dd59426
Compare
pior
force-pushed
the
fix-custom-command-env
branch
from
dd59426
to
6c71f98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The custom commands are run with the environment variables inherited from the shell, ignoring the
envsection of the manifest.Usually, the user would run
bud upwhen the manifest is changed to apply the change.But it's easy to miss this step, and be puzzled why the command does not work.
Injecting the envvars declared in the manifest in the custom command environment make sense until #406 is fixed and #30 is implemented.
How
If the envvar already exists in the shell environment, the envvar is not overridden.