Merge with Coinzen-Devcoin 0.9.2 and Bitcoin 22.0.0 (Bounty: 100M DVC)

[develCuy]

There is a more up to date version of Devcoin that was contributed by @sidhujag

https://github.com/coinzen/devcoin0.9.2MM/blob/master/src/clientversion.h

The reported version of current official devcoin is 0.8.5

https://github.com/devcoin/core/blob/master/src/clientversion.h

So we are still very far

[develCuy]

Devcoin 0.9.2 is older than OpenSSL 1.1.x, it means that a lot of fixes we already figured out would need rework. For example:

https://github.com/devcoin/core/pull/45/commits

Also, there are many old branches left by @belovachap and @sidhujag. Branch belovachap_devcoin0.9.2 was merged into devcoin0.9.2, yet it has one extra commit worth to rescue: 17d3bb3. Branches belovachap_1.0.0dev and 1.0.0dev are experimental versions of devcoin0.9.2, we can safely ignore them.

Additionally, commits at devcoin0.9.2MM are very important, because they show the steps to convert bitcoin into devcoin, we can learn a lot from @sidhujag's work.

Last but not least, from BIP 173 (Bitcoin 0.16.0) wallets have bech32 address format set by default, it should be set back P2PKH format for Devcoin.

[develCuy]

For the record, Devcoin Core 22.0.0 is being worked into branch 22.x, so we need to rename this issue

[cpsilent]

I had now this new problem executing make command in Linux Mint 19: debug linux mint19_02.txt

Curiously, in Kubuntu 20.04.3 LTS the code now compiled well, but I had another problem this time in the make install command: kubuntu20.04.3 LTS.txt

[develCuy]

@cpsilent apparently in Kubuntu you are out of space. My build env has about 4GB. The big in Mint 19 should not happen, please clone a frech copy and follow build again

[cpsilent]

@cpsilent apparently in Kubuntu you are out of space. My build env has about 4GB. The big in Mint 19 should not happen, please clone a frech copy and follow build again

Well, I got sweet-and-sour results with the new compile. Firstly, in Linux Mint 19 it shows a similar outcome as before. Here it is the compiling output: debug linux mint19_03.txt

On the other hand, I didn't compile again the Kubuntu build, I just thought that it was weird that I was running out of space when I had more than 500GB of free space. So, I added sudo to the make install command like this: sudo make install and lo and behold, it installed the new build in my system. It turned out it was a permission problem, after all. Initially, after I opened the new wallet for the first time, there was a problem with the database. So, I reran it using the -reindex option, repairing and updating it successfully. Here is a screen caption of the new wallet running pretty good and stable in Kubuntu without the reindex option:

Since the compile worked in Kubuntu, which was my main focus installation, I don't know if we should keep trying the Linux Mint on my side. It could be something weird due to the Virtual Box installation. The Virtual Machine never failed me like this in the past, though. I don't know. What do you think about this?

[develCuy]

@cpsilent your debug log shows that before the ./configure step you missed this one:

$ export BDB_PREFIX='/home/test/core/db4'

[cpsilent]

You were right! I skipped it foolishly. Thank you! I also added a bit more of space, because it was too tight for my taste. The compilation process in Linux Mint 19 in my Virtual Machine worked flawlessly this time! Here it is a caption of the wallet running:

As my Kubuntu build worked pretty well with my existing wallet, I tried this time to sync the blockchain from zero. I created a new wallet and it worked pretty fine. I think I can confirm the code is fine!

[develCuy]

@cpsilent, @Traxo7, can you guys pull and build again? I would like to test transfers and fees (see #100). You can create a new empty wallet to get a new address. Please report back here with tx ids and/or issues found. Thanks in advance!

[cpsilent]

I pulled and built the code again for Kubuntu and Linux Mint Virtual Machine (VM). I deleted the wallet created in the VM and synced it again from zero. I sent two separate coins from 8:25 pm to 8:31 pm, but after 3 hours they never got confirmed. Both are latest version 22. Here is a screen caption of the transactions:

This is the first transaction information:

Status: 0/unconfirmed, in memory pool
Date: 21/2/22 20:25
To: Testing from 0.22 to 0.22 15j7DZWayaieBxkfoDpMRrKgAA7GMpqiWj
Debit: -22.22000000 DVC
Comisión por transacción.: -1.28500000 DVC
Net amount: -23.50500000 DVC
Transaction ID: 50b7006fbc4d3d66fdb9bf42a0671c318234f2adce8721b28ee0731910526332
Transaction total size: 257 bytes
Transaction virtual size: 257 bytes
Output index: 0

Raw transaction:

01000000019da6d652c132aac486bc00b35479c1d9cfb0f09b0fc4f6d88c06033eabc15c50000000008a473044022030c74a7c193fa89fb9e4f95766b06f3fa7d4319957d87a79210ca86b527e2efb022058d89cc7bd562173c848bcf91a4fd75a0c058b1b176ff66bfdd9aa926ebf51f10141048cf44c288cf896b58fdc817400f0bd3cc34528d18202087e99ee1e71361ddabce5336167489aa0ff9dc7a545689704da2d5bd027696da350c06ce370c64f1b57feffffff0280077184000000001976a91433d729b0c8fa33701e18ef33b22039e23b402a3288ac603f3885110000001976a91407ae9392174665492256b360fb8ed3533c6f102088aca6b50700

This is the second transaction information:

Status: 0/unconfirmed, in memory pool
Date: 21/2/22 20:31
To: Testing from 0.22 to 0.22 1JzDHpMSHzKdMEZpeTdRbqQEyoQLutrp3y
Debit: -22.22000000 DVC
Comisión por transacción.: -1.28500000 DVC
Net amount: -23.50500000 DVC
Transaction ID: 6d1f4ba7a976a14dc65e2e4701fca2f2f55e8875f174b6b3948040d68a6a45dd
Transaction total size: 257 bytes
Transaction virtual size: 257 bytes
Output index: 1

Raw transaction:
01000000015663f86a251590cecc174031f630a5ffb0cfa614a85911704475f32d4ae861cd000000008a473044022059cf21550dddfd761ac9b850d7fda36076e40148304819e4f91794aef876e7d5022051b7db3719fddc19beba80f75f002a6a853af5b20fc4a52202bc889727870ed001410403ed1020c9e7845180622d6afd14d1f61a977f49e5e03c99a463931d940f9508c62988e608814b39900b04360019814a45c8a20000888d7dc9dc65bec7666189feffffff0260479245530000001976a9140ce5613d8cd841f522e07494b65fe7d60bf6ab0a88ac80077184000000001976a914c54c1b760c7c4d4e5213f32493c8f0d710f1a33588aca6b50700

[develCuy]

@cpsilent, I did try to send 1 Devcoin to your address, it worked after a second try:

Status: 1/unconfirmed
Date: 24 Feb 2022 02:25
To: 15j7DZWayaieBxkfoDpMRrKgAA7GMpqiWj
Debit: -1.00000000 DVC
Transaction fee: -1.28500000 DVC
Net amount: -2.28500000 DVC
Transaction ID: aeb86b90db3c956fd4f9cdaa759d2a40a61885dd2923b34dafda01a661f38a03
Transaction total size: 257 bytes
Transaction virtual size: 257 bytes
Output index: 0

You can try to resend your transactions the following way, open port 52333 in your VM, run the old devcoind (0.8.x) on your VM, wait for it to sync, then start your 22.x wallet with a command like this:

$ devcoind-qt -connect=IP #IP is your VM's IP address, make sure your host has access to your VM's port 52333

Then on your QT wallet, open the console an run:

sendrawtransaction 01000000019da6d652c132aac486bc00b35479c1d9cfb0f09b0fc4f6d88c06033eabc15c50000000008a473044022030c74a7c193fa89fb9e4f95766b06f3fa7d4319957d87a79210ca86b527e2efb022058d89cc7bd562173c848bcf91a4fd75a0c058b1b176ff66bfdd9aa926ebf51f10141048cf44c288cf896b58fdc817400f0bd3cc34528d18202087e99ee1e71361ddabce5336167489aa0ff9dc7a545689704da2d5bd027696da350c06ce370c64f1b57feffffff0280077184000000001976a91433d729b0c8fa33701e18ef33b22039e23b402a3288ac603f3885110000001976a91407ae9392174665492256b360fb8ed3533c6f102088aca6b50700

sendrawtransaction will manually broadcast the given transaction to the remote nodes. In this case, your wallet is connecting exclusively to the IP you provided via -connect. If you get any error from sendrawtransaction, please report here

[cpsilent]

I tried doing it in several ways but unfortunately, I couldn't make it work. This was the last stone I tripped over:

I don't know what else to do

[Satoshi0x]

I tried doing it in several ways but unfortunately, I couldn't make it work. This was the last stone I tripped over:

I don't know what else to do

emailed this fwd to @knotwork maybe he will pop in with a solution!

[develCuy]

@cpsilent, apparently your wallet.dat got upgraded by new Devcoin QT. Do you have a backup copy of your original wallet.dat?

[cpsilent]

@cpsilent, apparently your wallet.dat got upgraded by new Devcoin QT. Do you have a backup copy of your original wallet.dat?

Sorry, for answer this late. I was pretty busy. Well, I have a good backup of my old wallet, but the new one, inside the VM, it's a 0.22 only, unfortunately. I don't know if you are referring to my main old one, or the new test one.

[develCuy]

@cpsilent, if you create a wallet with 22.x (not 0.22) you can't open it with 0.8.x. Btw, you don't need to open the same wallet twice, you only need an old 0.8.x node running locally and helping you to broadcast the transaction, so you can create a new empty wallet with 0.8.x

[develCuy]

@cpsilent, @Traxo7, I just pushed new code with VERY important changes, please clone a fresh copy and perform the build again

[Satoshi0x]

Ok I tried and got so close. SO CLOSE. But somehow fudged the ending. Will attempt again tomorrow on my pathetic tech brain with a lil college try :)

[Satoshi0x]

my first 22.x Devcoin Core address: 1Kq7cdCaazPc6da5J2xktoiPZjxFMio6Wb

[cpsilent]

@cpsilent, I did try to send 1 Devcoin to your address, it worked after a second try:

Status: 1/unconfirmed Date: 24 Feb 2022 02:25 To: 15j7DZWayaieBxkfoDpMRrKgAA7GMpqiWj Debit: -1.00000000 DVC Transaction fee: -1.28500000 DVC Net amount: -2.28500000 DVC Transaction ID: aeb86b90db3c956fd4f9cdaa759d2a40a61885dd2923b34dafda01a661f38a03 Transaction total size: 257 bytes Transaction virtual size: 257 bytes Output index: 0

You can try to resend your transactions the following way, open port 52333 in your VM, run the old devcoind (0.8.x) on your VM, wait for it to sync, then start your 22.x wallet with a command like this:

$ devcoind-qt -connect=IP #IP is your VM's IP address, make sure your host has access to your VM's port 52333

Then on your QT wallet, open the console an run:

sendrawtransaction 01000000019da6d652c132aac486bc00b35479c1d9cfb0f09b0fc4f6d88c06033eabc15c50000000008a473044022030c74a7c193fa89fb9e4f95766b06f3fa7d4319957d87a79210ca86b527e2efb022058d89cc7bd562173c848bcf91a4fd75a0c058b1b176ff66bfdd9aa926ebf51f10141048cf44c288cf896b58fdc817400f0bd3cc34528d18202087e99ee1e71361ddabce5336167489aa0ff9dc7a545689704da2d5bd027696da350c06ce370c64f1b57feffffff0280077184000000001976a91433d729b0c8fa33701e18ef33b22039e23b402a3288ac603f3885110000001976a91407ae9392174665492256b360fb8ed3533c6f102088aca6b50700

sendrawtransaction will manually broadcast the given transaction to the remote nodes. In this case, your wallet is connecting exclusively to the IP you provided via -connect. If you get any error from sendrawtransaction, please report here

Sorry for the long delay. I successfully pushed the transaction using your method above described. However, to take it out of the VM wallet, I had to do the same, this time connecting to the old client coexisting in the VM. So, I can confirm the wallets aren't connecting to the nodes by themselves, only using the old client.

Here is the obligatory caption

@cpsilent, @Traxo7, I just pushed new code with VERY important changes, please clone a fresh copy and perform the build again

I did compile the new version, but the result was the same. Is it in another branch? I used the command git clone --branch 22.x https://github.com/devcoin/core.git to retrieve the new code. I feel we are closer now!!! Again, I'm so sorry for the delay!

[develCuy]

@cpsilent, great news! Let me answer point by point:

1. The actual bug is outgoing transactions not being included in new blocks, I don't know exactly why
2. What we know is that the new wallet is able to connect to existing 0.8.x and 22.x nodes, and to sync with the blockchain
3. Sometimes outgoing transactions work, sometimes doesn't. It might be due to some miners rejecting transactions generated from 22.x wallets, if so that miner should be running a very old version of Devcoin

If my hypothesis is correct, things should improve once we have at least one miner supporting 22.x. In the mean time we can't officially release the new wallet.

[cpsilent]

@cpsilent, I did try to send 1 Devcoin to your address, it worked after a second try:

Status: 1/unconfirmed Date: 24 Feb 2022 02:25 To: 15j7DZWayaieBxkfoDpMRrKgAA7GMpqiWj Debit: -1.00000000 DVC Transaction fee: -1.28500000 DVC Net amount: -2.28500000 DVC Transaction ID: aeb86b90db3c956fd4f9cdaa759d2a40a61885dd2923b34dafda01a661f38a03 Transaction total size: 257 bytes Transaction virtual size: 257 bytes Output index: 0

You can try to resend your transactions the following way, open port 52333 in your VM, run the old devcoind (0.8.x) on your VM, wait for it to sync, then start your 22.x wallet with a command like this:

$ devcoind-qt -connect=IP #IP is your VM's IP address, make sure your host has access to your VM's port 52333

Then on your QT wallet, open the console an run:

sendrawtransaction 01000000019da6d652c132aac486bc00b35479c1d9cfb0f09b0fc4f6d88c06033eabc15c50000000008a473044022030c74a7c193fa89fb9e4f95766b06f3fa7d4319957d87a79210ca86b527e2efb022058d89cc7bd562173c848bcf91a4fd75a0c058b1b176ff66bfdd9aa926ebf51f10141048cf44c288cf896b58fdc817400f0bd3cc34528d18202087e99ee1e71361ddabce5336167489aa0ff9dc7a545689704da2d5bd027696da350c06ce370c64f1b57feffffff0280077184000000001976a91433d729b0c8fa33701e18ef33b22039e23b402a3288ac603f3885110000001976a91407ae9392174665492256b360fb8ed3533c6f102088aca6b50700

sendrawtransaction will manually broadcast the given transaction to the remote nodes. In this case, your wallet is connecting exclusively to the IP you provided via -connect. If you get any error from sendrawtransaction, please report here

Sorry for the long delay. I successfully pushed the transaction using your method above described. However, to take it out of the VM wallet, I had to do the same, this time connecting to the old client coexisting in the VM. So, I can confirm the wallets aren't connecting to the nodes by themselves, only using the old client.

Here is the obligatory caption

@cpsilent, @Traxo7, I just pushed new code with VERY important changes, please clone a fresh copy and perform the build again

I did compile the new version, but the result was the same. Is it in another branch? I used the command git clone --branch 22.x https://github.com/devcoin/core.git to retrieve the new code. I feel we are closer now!!! Again, I'm so sorry for the delay!

@cpsilent, great news! Let me answers point by point:

1. The actual bug is outgoing transactions not being included in new blocks, I don't know exactly why

2. What we know is that the new wallet is able to connect to existing 0.8.x and 22.x nodes, and to sync with the blockchain

3. Sometimes outgoing transactions work, sometimes doesn't. It _might be_ due to some miners rejecting transactions generated from 22.x wallets, if so that miner should be running a very old version of Devcoin

If my hypothesis is correct, things should improve once we have at least one miner supporting 22.x. In the mean time we can't officially release the new wallet.

Well in that case, I think is great news, then! I thought it has something to do with the wallet itself, bu let's hope your hypothesis is correct and miners begin supporting the new wallet very soon! I hope next time I won't be so distracted to help you with this much faster! Cheers!

[Satoshi0x]

I was able to receive 1 DVC on Devcoin Core from my Devcoin-Qt 0.8.9.0 beta version on April 2, 2022 and I tested a payment to myself out of curiosity from Devcoin Core 22.x running on another computer April 16, 2022 so the outgoing txn had no problem confirming quickly from my Devcoin Core 22.x build. Wondering if you want us sending anything back from 22.x to Devcoin-Qt 0.8.9.0? Not sure if that would accomplish anything so I'm not messing around just yet but I guess it would be a way to send coins out from 22.x to an older version and not just to myself?

[develCuy]

@Satoshi0x, yes, we are testing transfers from the 22.x wallet. Also, worth to note that coins are transferred only if mining nodes accept a given transaction. Somehow transactions from 22.x wallets seem to be ignored by miners. It is not happening always but frequently enough to look for a fix. In the mean time 22.x is still beta

[Satoshi0x]

Just sent another from 0.8.9.x to 22.x. No problem. :P