Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docker-in-docker] Updates docker-init scripts #715

Merged
merged 2 commits into from
Oct 5, 2023
Merged

[Docker-in-docker] Updates docker-init scripts #715

merged 2 commits into from
Oct 5, 2023

Conversation

samruddhikhandale
Copy link
Member

  • If we run pkill on a process which is already terminated, then it returns exit code 1. This could result failing of the docker-init script. Hence, wrap it within set
  • Let's not kill docker daemon at the start of docker-init script if docker is running, if that is needed then the retry logic would take care of it.

@samruddhikhandale samruddhikhandale requested a review from a team as a code owner October 5, 2023 18:13
@samruddhikhandale samruddhikhandale merged commit 4fca96b into main Oct 5, 2023
111 checks passed
@samruddhikhandale samruddhikhandale deleted the samruddhikhandale/dnd-updates branch October 5, 2023 18:27
@samruddhikhandale samruddhikhandale mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshspicer joshspicer joshspicer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samruddhikhandale @joshspicer