Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Ubuntu 24 Noble to docker-in-docker #971

Merged
merged 2 commits into from
May 13, 2024
Merged

✨ Add Ubuntu 24 Noble to docker-in-docker #971

merged 2 commits into from
May 13, 2024

Conversation

jacobwoffenden
Copy link
Contributor

@jacobwoffenden jacobwoffenden commented May 13, 2024

This pull request resolves #967 by adding noble to the allowed codenames

Also includes a request to include ubuntu:noble in the test workflows (https://github-partners.slack.com/archives/C0431R35H37/p1715616382180099?thread_ts=1715589521.243939&cid=C0431R35H37)

Signed-off-by: Jacob Woffenden jacob@woffenden.io

Signed-off-by: GitHub <noreply@github.com>
@jacobwoffenden jacobwoffenden requested a review from a team as a code owner May 13, 2024 16:21
@jacobwoffenden jacobwoffenden changed the title ✨ Add Ubuntu 24 Noble ✨ Add Ubuntu 24 Noble to docker-in-docker May 13, 2024
.github/workflows/test-all.yaml Outdated Show resolved Hide resolved
.github/workflows/test-pr.yaml Outdated Show resolved Hide resolved
Signed-off-by: GitHub <noreply@github.com>
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks wonderful, thank you!

@samruddhikhandale samruddhikhandale merged commit 67c10a6 into devcontainers:main May 13, 2024
112 checks passed
@jacobwoffenden jacobwoffenden deleted the dind-noble branch May 13, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-in-docker: support noble
2 participants