Modernize frontend build #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update/remove gulp dependencies - reduce vulnerabilities by reducing the used dependencies - restructure gulp build to work with gulp 4
This commit removes the date output from the generated CSS to allow reproducible builds.
Pull Request Test Coverage Report for Build 3327642989
💛 - Coveralls |
There was a problem hiding this comment.
LGTM.
Only issue is: when I ran this locally and checked the start page, everything looked fine. But when I further inspected the developer console I got the following error:
Failed to load resource: the server responded with a status of 404 (Not Found) http://0.0.0.0:8000/static/js/bootstrap.js.map
This won't break functionality, but might be a regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR minimizes the frontend build system to the bare minimum to reproduce our current CSS and JavaScript.
The goal of the PR is to reduce dependencies. The build has been updated to Gulp 4, a recent nodejs release and updated versions of most dependencies. The PR fixes all critical vulnerabilities found by GitHub's dependency analysis.
Browsersync and watch functionality has been removed because it did not make sense with our setup (no static HTML to test with) anyway.