Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to poetry #298

Merged
merged 6 commits into from
Oct 26, 2022
Merged

Switch to poetry #298

merged 6 commits into from
Oct 26, 2022

Conversation

jandd
Copy link
Contributor

@jandd jandd commented Oct 11, 2022

pipenv is not maintained well anymore. This PR switches the dependency management to the more modern poetry.

@jandd jandd added build Docker, run.sh deployment dependencies Pull requests that update a dependency file labels Oct 11, 2022
@jandd
Use relative paths for python3 in venv
0fd905b 
Add the virtual env's bin directory to $PATH to allow relative paths for
python3 and coverage.
@jandd
Switch to a compatible set of dependencies
7d2e21a 
Use a set of dependencies compatible with Python 3.9 from Debian
Bullseye and our tests.
@coveralls
Copy link

coveralls commented Oct 11, 2022 •
edited

Pull Request Test Coverage Report for Build 3327847876

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 97.469%
Totals Coverage Status
Change from base Build 3327845523: 0.4%
Covered Lines: 3847
Relevant Lines: 3949
💛 - Coveralls

@jandd jandd mentioned this pull request Oct 12, 2022
Merged
@jenslauterbach jenslauterbach self-assigned this Oct 25, 2022
jenslauterbach
jenslauterbach approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@jenslauterbach jenslauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this change on my machine (Apple MacBook Air with M1).

Worked like a charm 👍

@jandd jandd merged commit 5c37d3d into devdaydresden:development Oct 26, 2022
@jandd jandd deleted the switch-to-poetry branch October 26, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenslauterbach jenslauterbach jenslauterbach approved these changes

Assignees

@jenslauterbach jenslauterbach

Labels
build Docker, run.sh dependencies Pull requests that update a dependency file deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jandd @coveralls @jenslauterbach