Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added logo for devday 23 #302

Merged
merged 1 commit into from
Nov 4, 2022
Merged

added logo for devday 23 #302

merged 1 commit into from
Nov 4, 2022

Conversation

artifactdev
Copy link
Contributor

added logo with number 23 for the next devday

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3394041784

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.469%
Totals Coverage Status
Change from base Build 3328678647: 0.0%
Covered Lines: 3847
Relevant Lines: 3949
💛 - Coveralls

jenslauterbach
jenslauterbach approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@jenslauterbach jenslauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Although I want to point out that the svg appears to be duplicated in the assets and static folder.

@artifactdev
Copy link
Contributor Author

Yeah like the others as well, assets are copied from source to the compiled static directory of the cms

@artifactdev artifactdev merged commit 848d161 into development Nov 4, 2022
@artifactdev artifactdev deleted the devday-23-logo branch November 4, 2022 13:23
jandd
jandd reviewed Nov 4, 2022
View reviewed changes
Copy link
Contributor

@jandd jandd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandd jandd jandd left review comments

@jenslauterbach jenslauterbach jenslauterbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@artifactdev @coveralls @jandd @jenslauterbach