Merge pull request #5 from cvtsi2sd/master

Fix undefined behavior in random_genXX helpers
develersrl · Jan 23, 2017 · 1f5efa0 · 1f5efa0
2 parents bce3c17 + 5e53f91
commit 1f5efa0
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/bertos/sec/random.h b/bertos/sec/random.h
@@ -94,21 +94,21 @@ void random_gen(uint8_t *out, size_t len);
 INLINE uint8_t random_gen8(void)
 {
 	uint8_t x;
-	random_gen(&x, 1);
+	random_gen(&x, sizeof(x));
 	return x;
 }
 
 INLINE uint16_t random_gen16(void)
 {
-	uint8_t x;
-	random_gen(&x, 2);
+	uint16_t x;
+	random_gen((uint8_t *)&x, sizeof(x));
 	return x;
 }
 
 INLINE uint32_t random_gen32(void)
 {
-	uint8_t x;
-	random_gen(&x, 4);
+	uint32_t x;
+	random_gen((uint8_t *)&x, sizeof(x));
 	return x;
 }