Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider having the JobDetails show in a separate Activity #450

Closed
codnee opened this issue Apr 24, 2016 · 5 comments
Closed

Consider having the JobDetails show in a separate Activity #450

codnee opened this issue Apr 24, 2016 · 5 comments

Comments

@codnee
Copy link
Contributor

codnee commented Apr 24, 2016

As a user with a small phone I want to be able to see the details of a position without having to scroll too much.

This is what the details screen currently looks like, only 2/3 of the screen are available for you to see the details of the position.

13059527_679963508809668_138011733_n

Moving the the JobDetails to its own Activity would give the user more space to see the content of the position and interact (share, up/down vote/comment...) with it.

@claudiosanchez @LuisAlbertoPenaNunez thoughts?

@claudiosanchez
Copy link
Contributor

Another strategy would be to make the current Layout change to hide the Search and header area.

@codnee
Copy link
Contributor Author

codnee commented Apr 25, 2016

Indeed. However, a separate activity would let us keep it simple, as we wouldn't be changing stuff in outer UI back and forth.

@LuisAlbertoPenaNunez
Copy link
Contributor

Even using a Fragment would make it even easier, since it's just a replace fragment transaction.
@codnee

@codnee
Copy link
Contributor Author

codnee commented Apr 25, 2016

Wouldn't we also have the menu options updated to give the user more interactions with the position? That is what I meant by saying we'd have to change the UI back and forth.

We could also make that other Activity Browsable with a custom scheme via its intent filter. So when a user shares a link it does not point to the website, but to the app.

@codnee
Copy link
Contributor Author

codnee commented Jun 11, 2016

@LuisAlbertoPenaNunez a replace fragment transaction will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants