Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add createContext to preact standalone bundle #146

Merged
merged 1 commit into from Jan 23, 2020
Merged

add createContext to preact standalone bundle #146

merged 1 commit into from Jan 23, 2020

Conversation

lmorchard
Copy link
Contributor

I think this fixes the issue I was scratching my head at!

fixes #145

developit
developit approved these changes Jan 23, 2020
View reviewed changes
Copy link
Owner

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup!

@developit
Copy link
Owner

we might also be able to get rid of useDebugValue, I don't really know what that hook is for haha

@jviide
Copy link
Collaborator

jviide commented Jan 23, 2020

Thanks, @lmorchard!

@jviide jviide merged commit 7623ca1 into developit:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preact standalone bundle includes useContext but not createContext
3 participants
@lmorchard @developit @jviide