fix: escape rollup external test items (#650)

developit · Jun 14, 2020 · 2a667c7 · 2a667c7
1 parent f4ab33d
commit 2a667c7
Show file tree

Hide file tree

Showing 3 changed files with 65 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -86,6 +86,7 @@
     "camelcase": "^5.3.1",
     "cssnano": "^4.1.10",
     "es6-promisify": "^6.0.1",
+    "escape-string-regexp": "^4.0.0",
     "filesize": "^6.1.0",
     "gzip-size": "^5.1.1",
     "kleur": "^3.0.3",

diff --git a/src/index.js b/src/index.js
@@ -21,6 +21,7 @@ import json from '@rollup/plugin-json';
 import logError from './log-error';
 import { readFile, isDir, isFile, stdout, stderr, isTruthy } from './utils';
 import camelCase from 'camelcase';
+import escapeStringRegexp from 'escape-string-regexp';
 
 const removeScope = name => name.replace(/^@.*\//, '');
 
@@ -506,7 +507,9 @@ function createConfig(options, entry, format, writeMeta) {
 
 	const useTypescript = extname(entry) === '.ts' || extname(entry) === '.tsx';
 
-	const externalPredicate = new RegExp(`^(${external.join('|')})($|/)`);
+	const externalPredicate = new RegExp(
+		`^(${external.map(escapeStringRegexp).join('|')})($|/)`,
+	);
 	const externalTest =
 		external.length === 0 ? id => false : id => externalPredicate.test(id);