New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Banner #116
Comments
Can I ask why you'd need this? |
I usually don't use this feature. But, some library authors like to use it. I think that may be useful to make easy the migration from others tools to microbundle, not requiring to stop using a banner to do the migration. |
Problem would be that it conflates the filesize. I think if we do this and the resulting banner'd file is measured for size, we should strip the comment when calculating. |
I think we should remove minification in the bundle by default anyways maybe run uglify in memory |
@ForsakenHarmony 👍 minification makes it harder to debug minified dependencies. Most common use case is to uglify with a bundler later - when building application. IMHO the only format that could be minified by default is UMD. Minifying "in memory" just to report size is IMHO also a good idea. I hope to prepare a PR for this (& more) soon-ish, planning to do it for so long already :s just not having enough time lately. |
It seems a shame to minify in-memory just to report size though. Why not write the files to disk as FWIW I 100% need minification for some of my use-cases for Microbundle. I guess it would be fine if |
It's already a flag, but I think off would be the better default but we'd still want the size Output |
tbh that depends whether you're using microbundle for web or node. we have the --target option, so we already know the answer in most cases. I use it a lot more for web, where optimize should be on by default. |
Would be great to add option to prepend a banner on the bundle, maybe using rollup-plugin-license on something similar.
The text was updated successfully, but these errors were encountered: