Added source-map option #79
Conversation
src/index.js
Outdated
| @@ -310,7 +310,7 @@ function createConfig(options, entry, format, writeMeta) { | |||
| strict: options.strict===true, | |||
| legacy: true, | |||
| freeze: false, | |||
| sourcemap: true, | |||
| sourcemap: options.sourcemap===true || options.sourcemap===undefined, | |||
There was a problem hiding this comment.
This can just be options.sourcemap since the default is set to true 馃槃
There was a problem hiding this comment.
Well that was my assumption as well, at first 馃檪. Seems that the cli would have it defined from sade as true, but running it through the node package, would end up undefined.
Did I get it right?
There was a problem hiding this comment.
I think it's because your first attempt was using sourceMap -- I just checked out your current branch it's working as expected. There's no need for any === checks 馃憤
There was a problem hiding this comment.
Ha, seems like @developit did some trickery check there to cover both cases, for default true options 馃槃just checking it that it's not false options.sourcemap!==false. That covers both cases, cli and node.
Node it's different, the options object it's not validated by sade just a plain config option.
There was a problem hiding this comment.
Right about here https://github.com/developit/microbundle/blob/master/src/index.js#L265 I was looking how the other always true values are behaving. And here's how the options are passed to microbundle function https://github.com/developit/microbundle/blob/master/test/index.test.js#L29.
There was a problem hiding this comment.
Those existed for Yargs, aka before the switch to Sade 馃槃 I didn't bother converting them to make the PR diff easier to follow.
Sade uses mri under the hood, which will always ensure that a flag value will be boolean|string|number if specified or if an initial value is provided.
There was a problem hiding this comment.
Ha, nice! That makes sense. Also, kudos on the mri 馃槂that's impressive perf, you got there.
There was a problem hiding this comment.
Haha, thanks 馃檭 Flag parsing perf doesn't matter too much for the majority of cases, but is nice to have. The simple utilities of type-casting & assumed booleans are more useful... allowing you avoid all these !== manual checks in your apps.
|
Hey @lukeed if there's anything else, let me know ;) |
|
Thanks! Totally needed this today haha |
I was missing this option, and I noticed @lukeed created a issue for it here #73 and you know, I had a few free minutes and why not, lend a hand. 馃槃
Let me know if this is out of scope, or not really something you'd like to go towards.