more precise type annotation for WildCardEventHandler #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I might have to ask @aweary for help reviewing 😇 |
aweary
suggested changes
Jun 15, 2017
src/index.js
Outdated
| // A map of event types and their corresponding event handlers. | ||
| type EventHandlerMap = { | ||
| '*': WildCardEventHandlerList, |
There was a problem hiding this comment.
I think this should be:
'*'?: WildCardEventHandlerListOtherwise, it means that EventHandlerMap should always have a "*" key
|
hi @aweary, I addressed your comment. Thank you! |
|
@developit @aweary is this good to merge? |
|
any progress on this? would be great to have this fixed, maybe @tunnckoCore can handle this? |
|
Hey, thanks for the ping. I'll try to review it soon :) |
|
Seems okey, probably... but i'm not so TS/Flow guy like @developit ;d |
developit
approved these changes
Jul 5, 2017
|
@developit one last thing - could this be released to npm? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an attempt to get away with the hack in type annotation from the previous fix