Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect extension removal in polyfill name replacement #29

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

rschristian
Copy link
Contributor

@rschristian rschristian commented Aug 25, 2022

Well this was a fun one to find...

Notably, it'll incorrectly convert core-js/modules/es.json.to-string-tag.js into core-js/modules/eson.to-string-tag.js. Funky name, to be fair.

console.warn
    'core-js/modules/eson.to-string-tag.js' is imported by entry, but could not be resolved – treating it as an external dependency

      at Graph.defaultOnWarn [as onwarn] (../../node_modules/optimize-plugin/node_modules/rollup/dist/shared/node-entry.js:13596:17)
      at Graph.warn (../../node_modules/optimize-plugin/node_modules/rollup/dist/shared/node-entry.js:13404:14)
      at ModuleLoader.handleResolveId (../../node_modules/optimize-plugin/node_modules/rollup/dist/shared/node-entry.js:12412:24)
      at ModuleLoader.<anonymous> (../../node_modules/optimize-plugin/node_modules/rollup/dist/shared/node-entry.js:12298:30)
      at fulfilled (../../node_modules/optimize-plugin/node_modules/rollup/dist/shared/node-entry.js:38:28)

@rschristian rschristian changed the title fix: Incorrect regex in polyfill name replacement fix: Incorrect extension removal in polyfill name replacement Aug 25, 2022
@qeleb
Copy link

qeleb commented Nov 15, 2022

@developit take a look at this? 🙏🏼

@rschristian
Copy link
Contributor Author

@developit Friendly ping, if you can take a peek.

Finally trying to push through a CLI v4 (or get it to a reviewable state, anyhow) and was reminded this is still an "issue" (not sure if it's likely to cause any actual problems, but it is a tad noisy).

Copy link
Owner

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha! damn me.

@developit developit merged commit 7f11c6a into developit:main Jan 9, 2023
@rschristian rschristian deleted the fix/bad-polyfill-replacement branch January 9, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants