(chore) - remove focusElement #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't take the Passing as it succeeds I have adjusted this in tests: Now it effectively tests with keys. Without keys it loses focus when the last insertion happens so insert 0 before 1. 'parent before' is first the existing parentDom and then adding a newDom before given oldDom |
JoviDeCroock
requested review from
marvinhagemeister,
andrewiggins and
developit
JoviDeCroock
commented
Apr 28, 2019
marvinhagemeister
approved these changes
Apr 28, 2019
|
🎉 |
lordvlad
added a commit
to lordvlad/preact
that referenced
this pull request
Apr 30, 2019
* upstream/master: (341 commits) Revert "Simplify originalDom check (-4 B) " Simplify originalDom check (-4 B) Add back mistakenly removed JSDoc comment Remove unnecessary code from `diffChildren` (-16 B) Golf createContext (-6 B) Fix useContext test spacing Remove `dom` parameter from `diff()` (-11 B) Move all component diff'ing logic into component diff condition (-6 B) fix issue by marking dirty before .render since this can potentially add another entry on the render queue add relevant test (chore) - remove focusElement (preactjs#1548) Update type definition (preactjs#1581) Compress code, assume EMPTY_OBJ._children == null Refactor out variables from diffChildren Compress diffChildren further Compress diffChildren further Condense code in diffChildren Fix infinite loop because of props mutation (preactjs#1577) (fix) - Error boundary not applying in array cases (preactjs#1572) Add styled-components example (preactjs#1574) ... # Conflicts: # .eslintignore # compat/mangle.json # compat/src/index.js # compat/src/internal.d.ts # debug/mangle.json # hooks/src/index.d.ts # hooks/src/index.js # hooks/src/internal.d.ts # mangle.json # package.json # src/component.js # src/constants.js # src/create-context.js # src/create-element.js # src/diff/children.js # src/diff/index.js # src/diff/props.js # src/index.d.ts # src/internal.d.ts # src/jsx.d.ts # src/render.js # src/util.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding items in react: https://codesandbox.io/s/748j0p3jpj
Swapping in react: https://codesandbox.io/s/olq48z68r5
So the first we should support, which also feels obviosu to me personally but the second not so much.
The odd thing is that it only fails when you insert a second thing above
So add one before --> works
Add one after --> works
Add one after previous --> works
Add one after the first step --> fails
Size of core stays the same
Seems to give a significant performance increase