(fix) - Error boundary not applying in array cases #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
requested review from
developit,
andrewiggins,
marvinhagemeister and
cristianbote
JoviDeCroock
changed the title
|
All checks are successfull in travis, but the performance things are still failing locally with Issue at hand if anyone knows more: No clue how to debug this perf build at this moment. Travis only completes 480/600 tests and then reports a success. |
|
Okay, I think all is fixed now! :D |
| @@ -58,6 +58,7 @@ export interface Component<P = {}, S = {}> extends preact.Component<P, S> { | |||
| _prevVNode?: VNode | null; | |||
| _ancestorComponent?: Component<any, any>; | |||
| _processingException?: Component<any, any> | null; | |||
| _pendingError?: Component<any, any> | null; | |||
There was a problem hiding this comment.
Nit: We need to add this to our mangling properties to avoid potential name clashes.
There was a problem hiding this comment.
Does it matter what name I give it? Was wondering that since I see clashing names in mangle and that worries me to pick one.
There was a problem hiding this comment.
Mangling this to __E actually adds 3B
There was a problem hiding this comment.
The default is to mangle _ properties to single-letter variables, so that makes sense. However, we want to avoid single-letter property names since they're likely to collide.
marvinhagemeister
approved these changes
Apr 25, 2019
developit
approved these changes
Apr 26, 2019
lordvlad
added a commit
to lordvlad/preact
that referenced
this pull request
Apr 30, 2019
* upstream/master: (341 commits) Revert "Simplify originalDom check (-4 B) " Simplify originalDom check (-4 B) Add back mistakenly removed JSDoc comment Remove unnecessary code from `diffChildren` (-16 B) Golf createContext (-6 B) Fix useContext test spacing Remove `dom` parameter from `diff()` (-11 B) Move all component diff'ing logic into component diff condition (-6 B) fix issue by marking dirty before .render since this can potentially add another entry on the render queue add relevant test (chore) - remove focusElement (preactjs#1548) Update type definition (preactjs#1581) Compress code, assume EMPTY_OBJ._children == null Refactor out variables from diffChildren Compress diffChildren further Compress diffChildren further Condense code in diffChildren Fix infinite loop because of props mutation (preactjs#1577) (fix) - Error boundary not applying in array cases (preactjs#1572) Add styled-components example (preactjs#1574) ... # Conflicts: # .eslintignore # compat/mangle.json # compat/src/index.js # compat/src/internal.d.ts # debug/mangle.json # hooks/src/index.d.ts # hooks/src/index.js # hooks/src/internal.d.ts # mangle.json # package.json # src/component.js # src/constants.js # src/create-context.js # src/create-element.js # src/diff/children.js # src/diff/index.js # src/diff/props.js # src/index.d.ts # src/internal.d.ts # src/jsx.d.ts # src/render.js # src/util.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where a series of components would throw the ErrorBoundary would get skipped since
_processingExceptionwould be filled. This check made for it to be skipped and thus thrown resulting in faulty behavior.This change seems to break testing in some way... :/ wondering if this could be something to do with cleaning up tests or related?
Tests seem to run really inconsistent, anyone has any clue as to why this could happen...
Like I know it probably loops or something somewhere but I can't tell where since I have no error output, I'm also having difficulties seeing how _processingException is bypassing that.
Fixes: #1570
Removes 23B from coreAdds 8B to core