Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #171 - remove warnings about deprecated hook on react 16.9.0^ #172

Merged
merged 4 commits into from
Jun 17, 2020

Conversation

Akiyamka
Copy link
Contributor

This will fix issue with warnings.
Probably will be better migrate to getDerivedStateFromProps hook with null return, but I not sure how I can call static method it this case

@eduardoborges
Copy link
Contributor

Very nice ;)

Akiyamka and others added 2 commits November 14, 2019 12:30
Co-Authored-By: Jason Miller <developit@users.noreply.github.com>
@Komzpa
Copy link

Komzpa commented Dec 2, 2019

Hi! Can this be merged, or is there any other thing to adjust? :)

@lohfu
Copy link

lohfu commented Dec 27, 2019

@Akiyamka hello stranger. i opened a couple of pull requests with rather substantial changes that i personally think greatly improves unistore and was looking for some feedback on. i'm assuming @developit is busy and meanwhile i was hoping to get this feedback from elsewhere. since you have opened a pull request yourself i assume you are familiar with the package and would love to hear what you think about the changes i propose. you can find them at #182 and #183. the second one builds upon the changes from the first.

@38elements 38elements mentioned this pull request Mar 14, 2020
@hesselbom
Copy link

@developit Any chance this could be merged? :)

@hesselbom
Copy link

For context, my reason for wanting this PR merged is because when using unistore with React Native we get this deprecation warning on every reload.

Screenshot 2020-05-22 at 14 41 42

@developit
Copy link
Owner

@hesselbom ooh, that's quite the intrusive warning. I'll try to get this merged and cut a release today.

@lohfu
Copy link

lohfu commented May 22, 2020

@developit it was very simple to rewrite the react integration to use hooks instead and the size shrunk considerably. i have a WIP at #186

@developit developit merged commit eafd796 into developit:master Jun 17, 2020
@developit
Copy link
Owner

Published as 3.5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants