Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing bones suffix #60

Closed
miccolis opened this issue Jul 24, 2012 · 5 comments
Closed

Consider changing bones suffix #60

miccolis opened this issue Jul 24, 2012 · 5 comments
Assignees

Comments

@miccolis
Copy link
Contributor

I hate to bring this up, but I suspect we will be better off if we get our .bones suffixed files back into .js land. I've been using jscoverage on a bones project and I've had to hack it to instrument bones files. The change in the patch is very short but I think indicative of a class of problems that our custom file extension can create.

-  if (string_ends_with(file, ".js")) {
+  if (string_ends_with(file, ".js") || string_ends_with(file, ".bones")) {
@yhahn
Copy link
Collaborator

yhahn commented Jul 24, 2012

Hrm, quick tests indicate we could switch the require.extensions declaration from .bones => .bones.js.

Maybe for bones 3?

@kkaefer
Copy link
Collaborator

kkaefer commented Jul 24, 2012

I like .bones.js

@AdrianRossouw
Copy link

indeed. and jshint/jslint will start working again

@ghost ghost assigned miccolis Jul 25, 2012
@miccolis
Copy link
Contributor Author

The changes to make this possible aren't quite as clean as I'd like, see 4c9ad45#L2R38

However I think it's tolerable. If there is consensus that this looks good I'll add a couple more tests that check that all private routers and view (in addition to the models where are tested) don't end up client site, and update the example.

@miccolis
Copy link
Contributor Author

Let's move the conversation over to the pull request #61

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants