Add sub-table name for dynamodb storage #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.table_name = table_id[0] | ||
| if len(table_id) > 1: | ||
| self.subtable_name = table_id[1] | ||
|
|
||
| self.region = parsed.netloc or self.region |
There was a problem hiding this comment.
what do you think about making region mandatory in the path?
There was a problem hiding this comment.
I think it would be fine to make that explicit.
|
@kylebarron thanks for starting this! With help from @leothomas I've created a new PR to handler this #127 |
| validator=attr.validators.in_(AWS_REGIONS), | ||
| ) | ||
| table_name: str = attr.ib( | ||
| init=False, validator=attr.validators.matches_re(r"^[a-zA-Z0-9\_\-\.]+$") |
There was a problem hiding this comment.
@kylebarron validators only run on init, so this won't work
There was a problem hiding this comment.
@kylebarron because the table_name is set during the __post_init the validation is not happening! you'll need to re-run the validation at the end of the __post_init__
| table_name: str = attr.ib(init=False) | ||
| region: str = attr.ib( | ||
| default=os.getenv("AWS_REGION", "us-east-1"), | ||
| validator=attr.validators.in_(AWS_REGIONS), |
There was a problem hiding this comment.
I prefer not having a list to validate to because everytime AWS will add a new region we will need a new release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116
subtable_namedoesn't sound greatdynamodb://{region}/{table_name}:{subtable_name}. A colon is not a valid DynamoDB table identifiercogeo_mosaic/backends/dynamodb.py:64: error: Module has no attribute "matches_re"It would probably also be good to have
deletemethod, so that you can delete one of the subtables. This would read the metadata for a single subkey and then iterate over its quadkeys, calling a delete operation on each one-2(?) (since we already use-1for the mosaic metadata), and have it contain a list of strings that are the subkeys that exist in the table. This would need to stay updated with the CRUD operations.overwrite=True.