Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder backend methods and raise error when backend is read-only #162

Merged
merged 3 commits into from Feb 4, 2021

Conversation

vincentsarago
Copy link
Member

This PR does:

  • reorder methods within backends for better visibility
  • remove mosaic_def in __init__ for read-only backends
with HttpBackend(url, mosaic_def=mosaic): 
     pass

☝️ this will now raise a TypeError with mosaic_def not in init method.

  • add minzoom/maxzoom/bounds default for the backends (those are mandatory for the BaseReader but we never really set them. They are not set from the mosaicjson doc)

@vincentsarago vincentsarago merged commit 337be15 into master Feb 4, 2021
@vincentsarago vincentsarago deleted the backendCleanup branch February 4, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant