Add Azure Blob Storage backend #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can see the tests are failing due to missing dependencies. Not sure how you want to handle this - it seems that e.g. boto3 is an indirect dependency of rio-tiler and thus installed as a runtime requirement which makes S3 tests succeed. |
|
Hi @vincentsarago! Sorry for tagging you explicitly, but since you seem to be the main contributor - is this project still active? |
|
sorry @christoe, I am the main contributor and sadly I have a lot other priority right now :-( |
|
@christoe in order to allow the CI to run tests you must add |
|
@vincentsarago Thanks and I totally understand. I was able to get the tests running now. |
vincentsarago
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I implemented support for Azure Blob Storage as a backend, inspired by the s3 and GS backends that already existed. I tried documenting and writing tests also based on what as available in the repo. Please get back to me if you have any feedback.
Thanks!