sketch supermorecado #203
sketch supermorecado #203
Conversation
| """Burn geometries to Tiles.""" | ||
| bounds = find_extrema(polys) | ||
| bounds = self.find_extrema(polys, truncate=truncate) |
There was a problem hiding this comment.
I have added a truncate options because for sometimes you could want to create tiles outside the tms bbox
|
@AndrewAnnex I'll wait for your 👍 to merge this then we can look at the other part of the code that will need a change |
|
I think it looks great, haven’t tried to test it with titiler yet though as some updates are needed there to accept other TMSs.- Dr. Andrew AnnexOn Mar 13, 2023, at 2:47 AM, Vincent Sarago ***@***.***> wrote:
@AndrewAnnex I'll wait for your 👍 to merge this then we can look at the other part of the code that will need a change
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Yes a lot needs to happen for this |
|
This is awesome to see. What is the best way to assist on this? I see that reviews are good to go and tests are in for WebMercator. Is it appropriate to test with another TMS and start to see where else breakages occur? |
|
👋 sorry I've been busy on other projects. |
|
@vincentsarago no worries - we are all juggling a ton! This PR LGTM! 🚀 Once this merges I'll get some tests for other TMSes PRed in. |
ref #202
Note: There will be a long way to go for full TMS support