Background ratio #159
Merged
Background ratio #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wronk
suggested changes
Dec 10, 2019
There was a problem hiding this comment.
I think we want to set the example's background ratio to 0 now to make users explicitly say if they want background tiles or not. For users doing multiclass classification who didn't want background tiles (like in the example), this would change their output.
Let's also remove the change to download_tile_tms and handle that bug here
|
@martham93 can you also update the parameters docs page to clarify this change? Otherwise good to go |
|
thanks @drewbo, the parameters docs are now updated |
|
Merging, thanks @martham93 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates to
images.pyso background ratio will apply to multi-class classification data sets, not just single class. Additional information in issue 158Once this change is approved we will need to do a new release for FFDA, so this PR also addresses small bug in
download_tile_tmsfunction arguments fromutils.py, to get that fix in the latest release.