Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip #147

Merged
merged 11 commits into from
Oct 25, 2023
Merged

Add tooltip #147

merged 11 commits into from
Oct 25, 2023

Conversation

vgeorge
Copy link
Member

@vgeorge vgeorge commented Oct 25, 2023

Contributes to #36. This is a work in progress.

Changes:

  • Enabled tooltip on hover for all layers
  • Defined a common getTooltip() function that generates a formatted table with the feature properties
  • Modified the build watcher to observe .css files

Issues:

  • Feature properties don't appear to be available in info.object. Should we deserialized them from the arrow object?
  • A small black square appears beneath the tooltip

cc @kylebarron

@kylebarron
Copy link
Member

Should be fixed with my latest commit:

image

@kylebarron
Copy link
Member

kylebarron commented Oct 25, 2023

My changes:

  • Set pickingRadius to 10 pixels to make it easier to pick small objects
  • Return only the content of the html div from getTooltip
  • Call toJSON() on the Arrow object
  • Delete the geometry attribute from the tooltip

@kylebarron
Copy link
Member

Feel free to merge whenever!

@vgeorge vgeorge merged commit 03c650d into main Oct 25, 2023
4 checks passed
@vgeorge vgeorge deleted the vgeorge/add-tooltip branch October 25, 2023 18:20
@vgeorge vgeorge mentioned this pull request Oct 27, 2023
@kylebarron kylebarron mentioned this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants