Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tooltip styles #151

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Fix tooltip styles #151

merged 3 commits into from
Oct 27, 2023

Conversation

vgeorge
Copy link
Member

@vgeorge vgeorge commented Oct 27, 2023 •
edited

Fix some issues of #147. Changes:

  • Move tooltip wrapper styles from CSS file to style property. They aren't taking effect because of inline styles
  • Make table border and property id font lighter

@kylebarron ready for review.

kylebarron
kylebarron approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@kylebarron kylebarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/tooltip/index.ts Outdated Show resolved Hide resolved
@vgeorge @kylebarron
Update src/tooltip/index.ts
f619c8b 
Co-authored-by: Kyle Barron <kyle@developmentseed.org>
@vgeorge vgeorge merged commit 11bfc42 into main Oct 27, 2023
4 checks passed
@vgeorge vgeorge deleted the vgeorge/tooltip-styles branch October 27, 2023 15:06
@kylebarron kylebarron mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebarron kylebarron kylebarron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vgeorge @kylebarron