Improve map height

[vgeorge]

Contributes to #167, WIP.

With this change, if the user doesn't set _height to Map, the component will try to dynamically occupy the full height of the parent element.

This will make the map height when using Sidecar to occupy the full height, which is nice, but it will require the user to know that _height must be set when not using sidecar, otherwise, the widget will look like this:

I believe we need to figure out how to set a default minHeight so the map would display well on both use cases.

cc @kylebarron

[vgeorge]

@kylebarron I added min-height to the widget wrapper and it seems to be working, could you please review?

[kylebarron]

This doesn't seem to be working for me without sidecar in JupyterLab...

After I manually set the height it works again

[kylebarron]

I'm not sure if the latest change to have a single uuid div per map works either... Ideally we want to have a unique id per view not a unique id per model. For example, it still breaks if I first render a map inline and then try to move the map to a sidecar:

notebook code:

import geopandas as gpd
from lonboard import viz
from sidecar import Sidecar

gdf = gpd.read_file(gpd.datasets.get_path('nybb'))
map_ = viz(gdf)
map_

sidecar = Sidecar()
with sidecar:
    display(map_)

presumably it's finding the wrong div

[kylebarron]

Oh smart, that looks great! Thanks!