Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let widget fill available height #167

Closed
kylebarron opened this issue Oct 30, 2023 · 2 comments
Closed

Let widget fill available height #167

kylebarron opened this issue Oct 30, 2023 · 2 comments
Labels
javascript Relates to JS bindings

Comments

@kylebarron
Copy link
Member

When using with jupyter sidecar, the map can be placed on the right side of the notebook screen:

image

Right now the div containing the deck.gl widget is hard-coded to 500px:

<div style={{ height: 500 }}>

This means that when used with sidecar, if the screen is more than 500px tall, it'll have a weird empty space at the bottom.

Ideally we want to let the widget fill all available height in its containing div, but I can't figure out how to do that. When I switch to, say,

style={{ display: "flex", flexFlow: "column", flexGrow: 1, overflow: "auto" }}

it creates a div with zero height:
image

cc @vgeorge

@kylebarron kylebarron added the javascript Relates to JS bindings label Oct 30, 2023
@kylebarron
Copy link
Member Author

Closed by #220

@kylebarron
Copy link
Member Author

HTML map height is tracked in #247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Relates to JS bindings
Projects
None yet
Development

No branches or pull requests

1 participant