Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null checks #331

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Fix null checks #331

merged 3 commits into from
Jan 26, 2024

Conversation

kylebarron
Copy link
Member

@kylebarron kylebarron commented Jan 26, 2024

Previously we had never been passing on falsy values to the deck.gl layer. Now, we try to be more consistent about initializing values to None, which get converted to null on the JS side. Then we check explicitly for null before passing values to deck layers.

Closes #274

@kylebarron kylebarron enabled auto-merge (squash) January 26, 2024 19:13
@kylebarron kylebarron merged commit 2202230 into main Jan 26, 2024
5 checks passed
@kylebarron kylebarron deleted the kyle/fix-null-checks branch January 26, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure correct checking for undefined/boolean when constructing props
1 participant