Document Panel in-place updates #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
reviewed
Jun 5, 2024
kylebarron
reviewed
Jun 5, 2024
There was a problem hiding this comment.
This looks amazing! Thank you!
Ideally we would remove the _height parameter... I assume you tested that and it didn't work without it? Happy to merge and not block on that, but maybe with a comment somewhere saying that the _height parameter is subject to change in the future.
|
Thanks for the feedback @kylebarron. I believe I've addressed the comments. Let me know if there is more I should do. Thanks. |
kylebarron
approved these changes
Jun 5, 2024
| cities_map = Map(layer) | ||
|
|
||
| # Fit to the available space | ||
| cities_map.layout.height = cities_map.layout.width = "100%" |
There was a problem hiding this comment.
oh cool. TIL. Maybe we should be setting this from the Lonboard side.
|
Thanks! I kicked off a docs build, so this should be on the website shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Panel documentation to demonstrate that it is in fact possible to make efficient, in-place updates of a map instead of replacing a map in its entirety.