Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Ipywidgets reference guide #6892

Closed
wants to merge 7 commits into from

Conversation

MarcSkovMadsen
Copy link
Collaborator

Working on developmentseed/lonboard#539 and reading the questions in developmentseed/lonboard#262 I released that the Ipywidgets reference guide does not explain fully how Panel supports ipywidgets.

This PR adds the missing explanations.

I've also found inspiration in the Shiny docs https://shiny.posit.co/py/docs/jupyter-widgets.html. Thanks to Shiny.

@MarcSkovMadsen MarcSkovMadsen added this to the v1.5.0 milestone Jun 5, 2024
@MarcSkovMadsen MarcSkovMadsen added type: enhancement Minor feature or improvement to an existing feature type: docs Related to the Panel documentation and examples ready for review labels Jun 5, 2024
@philippjfr
Copy link
Member

If you want to convert your ipywidget to a Panel native widget, you can do so with Panel's AnyWidgetComponent, JSComponent, or ReactComponent.

These links won't be correct, should be ../custom_components/....

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.54%. Comparing base (cdcd074) to head (883eb7b).
Report is 90 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6892       +/-   ##
===========================================
+ Coverage   22.10%   81.54%   +59.44%     
===========================================
  Files         314      319        +5     
  Lines       46326    46915      +589     
===========================================
+ Hits        10240    38259    +28019     
+ Misses      36086     8656    -27430     
Flag Coverage Δ
unitexamples-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcSkovMadsen
Copy link
Collaborator Author

If you want to convert your ipywidget to a Panel native widget, you can do so with Panel's AnyWidgetComponent, JSComponent, or ReactComponent.

These links won't be correct, should be ../custom_components/....

Thanks. Fixed.

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Jun 5, 2024

I changed the Sizing section to recommend fixing issues by settings widget.layout.width=widget.layout.height="100%". At least that works for ipyleaflet and lonboard. After that the IPyWidget pane can control the sizing.

I believe this is ready. Let me know if there is more I should do. Thanks.

@MarcSkovMadsen
Copy link
Collaborator Author

Super seeded by #6912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review type: docs Related to the Panel documentation and examples type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants