-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Batch AOI stats #139
Fix Batch AOI stats #139
Conversation
…e 'Class distribution metrics are not available' )
@vgeorge I'm a bit confused. I tested with a new batch prediction - please see the below. Some minor changes perhaps could be useful:
![]() My batch prediction returned, but the secondary stats panel doesn't load: Reloading the browser window, I can see the class stats should be there: Initially when I reloaded, the secondary panel didn't appear. My screenshot for this didn't save. I'll try to reproduce. Reloaded after new AOI:
![]() |
</Prose> | ||
</ClassItem> | ||
)} | ||
<ClassItem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{landArea(checkpoint.analytics[i][metric])} | ||
</Prose> | ||
)} | ||
<Prose size='small' className='percent'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep conditional check - only need this column of data on the class distribution chart, but the component is also used for class F1 scores
@vgeorge I added a change to keep the land area in the compare and share pages' class analytics charts. Not sure if best practice to execute the |
@LanesGood I added changes on how the batch status is controlled internally. Now there is a specific machine to control its state. I haven't gotten to the issues you reported, but it would be nice if you could review this again, specifically the batch panel behaviour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I see the batch progress in the button! Remarkably fast, so while I saw the progress increasing I didn't actually snap a screenshot of it in time. 🎉
-
Batch finishes but does not render 😞
Console of state machine exposes this:ckpt: undefined | aoi: 145 | tmf: undefined | msc: a1b11210f9ecc3fdc461c9379d6f0d53
Reloading, I can see the batch predictions:
@vgeorge I think we should call this PR good - it achieved the "fix batch aoi stats" goal and is successful. The rendering is something else. I also think that the expected behavior is usually that users start a batch and return to that page later, so that may be why the immediate rendering of the batch AOI predictions is not inherent already.
I do see that the "run batch prediction" button is still active on a selected AOI when nothing has changed - this isn't captured by your test cases but perhaps we can flag for future enhancement,
app/assets/scripts/components/project/sec-panel/class-analytics-chart.js
Outdated
Show resolved
Hide resolved
app/assets/scripts/components/project/sec-panel/class-analytics-chart.js
Outdated
Show resolved
Hide resolved
app/assets/scripts/components/project/sec-panel/class-analytics-chart.js
Outdated
Show resolved
Hide resolved
app/assets/scripts/components/project/sec-panel/class-analytics-chart.js
Outdated
Show resolved
Hide resolved
app/assets/scripts/components/project/sec-panel/class-analytics-chart.js
Outdated
Show resolved
Hide resolved
…s-chart.js Co-authored-by: Lane Goodman <lane@developmentseed.org>
…s-chart.js Co-authored-by: Lane Goodman <lane@developmentseed.org>
…s-chart.js Co-authored-by: Lane Goodman <lane@developmentseed.org>
@LanesGood thanks for the review! I've incorporated some of your suggested changes and added a commit to fix the styles in the secondary panel. I'm going to merge this now. Let's track any new issues in the panel with separate tickets. |
Contributes to #132.
Changes:
Class distribution metrics are not available
, hide the panel instead@LanesGood this is ready for review. To test, try opening a finished batch AOI, switch between AOIs and confirm the stats are displayed accordingly.