-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance mosaic selector #88
Conversation
@vgeorge good point on the PC "Most recent" label. Would it be possible to grab every mosaic name except for the latest, and generate a new name for that one? |
@LanesGood the 'Most recent' preset comes from PC data API, not the PC STAC API. They are hardcoded values generated by PC's team and we don't have any control over it. While 'most recent' preset exist for both Sentinel 2 and NAIP, there are other collections that do not follow this scheme. A more future-proof approach is to use the acquisition start and end, which is part of the STAC API to generate our quartely presets. This is how I implemented now. This is ready for review. You should be able to:
Additional notes:
Please let me know if you have any questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vgeorge looking good! I've pushed up some changes for the styles.
Two items I noticed that would be best to change:
The Mosaic name is still set to the long name, even though the modal displays the short name. Ex, I picked Dec - Feb 2023
in the modal, but the panel then says Sentinel 2 Level-2A 2023-12-27 11:25UTC...
Also it looks like I can change the end date after setting the start date. I can even set an end date prior to my start date! Do we still want to limit this to just 90 days, and have a disabled end date?
...cripts/components/project/prime-panel/tabs/predict/mosaic-selector/sections/create-mosaic.js
Show resolved
Hide resolved
… loading, reduce min-height to fit smaller screens
@LanesGood thanks for the review and the styles updates. I added the following changes:
Can you please do another review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vgeorge looking good! I like the minimum height setting on the modal
I do notice that the minimum 24 hours difference between mosaic start and end means that I need to have an end date of at least 2 days later. This makes sense if I think about it, but should we change the text to "end date must be 2 days..."?
Two other non-blocking things I note that could be enhancements:
- add helper text explaining why a user might not see anything in the mosaic (if very dark, not enough scenes, and if blank, not long enough period for image collection, etc)
- explore keeping the separator between mosaics as a dash
-
to match mosaic selection
Finally, I made a minor style change to group start + end date in one line.
@LanesGood thanks for the updates, it looks great. I agree with your suggestions and updated added the first and the third. Let's track the remaining as an enhancement. |
This contributes to #85. In this PR I intent to connect the mosaic selector modal to the Planetary Computer API in order to fetch mosaic presets and temporal extends of collections. This is WIP, opening for visibility.
Current changes:
To do:
@LanesGood Now I'm wondering if using mosaic presets from PC is a good approach. The first preset is 'Most recent (low cloud)'. On Pearl, this label will be displayed for exported predictions maps that might have been generated over one year ago, causing an inaccuracy. We might need to generate the season presets in UI, using the temporal extend of the collection provided by PC STAC API.