This repository has been archived by the owner on Mar 17, 2019. It is now read-only.
Completed Products API Implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had an issue with the commits being attributed correctly to me as my business partner hijacked my email. Hence the empty commits to fix authorship. Otherwise the pull request should be clean. |
devfacet
added a commit
that referenced
this pull request
Jun 1, 2014
Completed Products API Implementation
|
Nice work... Thanks for your contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed some of the rest of the APIs so I refactored the code a bit and added them. I added tests for all ASIN-based tests (all pass) based on the existing tests.
I tried to stick to conventions of style etc.
I'm happy to continue to help continue improving the code and tests as time permits. I hope this is useful to others!