This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
Change require to not access NativeModules directly, but rather via "… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…react-native" and make library compatible with React Native ^0.7.0
|
Quite a few libraries have needed to implement this change with the new versions of React Native. I was using your library (thanks by the way) for older versions and now upgrading and encountered the errors listed here: facebook/react-native#1808 The way RNGeocoder is required in index.js seems to be all that needs to be changed. |
devfd
added a commit
that referenced
this pull request
Aug 9, 2015
Change require to not access NativeModules directly, but rather via "…
|
Hi @umfana nice of you submitting a PR. Thanks |
orhan
pushed a commit
to orhan/react-native-geocoder
that referenced
this pull request
Mar 21, 2017
Update headers for RN@0.40.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…react-native" and make library compatible with React Native ^0.7.0