Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy support and the ability for clients to override the HTTP timeout #926

Closed
kim-tsao opened this issue Sep 12, 2022 · 1 comment
Closed

Add proxy support and the ability for clients to override the HTTP timeout #926

kim-tsao opened this issue Sep 12, 2022 · 1 comment
Assignees
@kim-tsao
Labels
kind/bug Something isn't working
Projects
Sprint 226

Comments

@kim-tsao
Copy link
Contributor

kim-tsao commented Sep 12, 2022 •
edited

/kind bug

Which area this bug is related to?

/area library
/area registry

Bug Summary

Describe the bug:

Dev console is running into issues creating an app in a disconnected cluster with a proxy using our Go devfile sample. The problem is with the parent devfile reference which the parser needs to read but because the HTTP client we construct does not contain proxy support, this action fails. We should also allow clients to override the default http request/response timeouts - default timeout of 30s has shown to be way too long of a wait (true for both the parser and registry library)

To Reproduce:

Expected behavior

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable.

Additional context

Any workaround?

Suggestion on how to fix the bug
@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Sep 12, 2022
@kim-tsao kim-tsao self-assigned this Sep 12, 2022
@kim-tsao kim-tsao mentioned this issue Sep 12, 2022
Merged
4 tasks
@kim-tsao kim-tsao changed the title Devfile Library: Add proxy support and the ability for clients to override the HTTP timeout Add proxy support and the ability for clients to override the HTTP timeout Sep 12, 2022
This was referenced Sep 12, 2022
Merged
Open
kim-tsao added a commit to kim-tsao/registry-support that referenced this issue Sep 19, 2022
@kim-tsao
backport proxy support. Includes fixes for both devfile/api#926 and d…
2396312 
…evfile/api#897

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@kim-tsao kim-tsao mentioned this issue Sep 19, 2022
Merged
3 tasks
kim-tsao added a commit to devfile/registry-support that referenced this issue Sep 19, 2022
@kim-tsao
backport proxy support. Includes fixes for both devfile/api#926 and d…
3f85c85 
…evfile/api#897 (#139)

Signed-off-by: Kim Tsao <ktsao@redhat.com>

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@kim-tsao kim-tsao mentioned this issue Sep 21, 2022
Closed
@kim-tsao kim-tsao reopened this Oct 17, 2022
@kim-tsao
Copy link
Contributor Author

re-opening for backports

@kim-tsao kim-tsao mentioned this issue Oct 17, 2022
Merged
5 tasks
@kim-tsao kim-tsao added this to Under consideration in Sprint 225 via automation Oct 17, 2022
@kim-tsao kim-tsao moved this from Under consideration to In progress in Sprint 225 Oct 17, 2022
@johnmcollier johnmcollier removed this from In progress in Sprint 225 Oct 18, 2022
@johnmcollier johnmcollier added this to Under consideration in Sprint 226 via automation Oct 18, 2022
@johnmcollier johnmcollier moved this from Under consideration to Review in progress in Sprint 226 Oct 18, 2022
@johnmcollier johnmcollier moved this from Review in progress to In progress in Sprint 226 Oct 18, 2022
@kim-tsao kim-tsao mentioned this issue Oct 18, 2022
Merged
5 tasks
Sprint 226 automation moved this from In progress to Done Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kim-tsao kim-tsao

Labels
kind/bug Something isn't working
Projects
No open projects
Sprint 226
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kim-tsao