Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry library needs to support accessing devfiles over a proxy #897

Closed
johnmcollier opened this issue Jul 27, 2022 · 1 comment
Closed
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working
Projects

Comments

@johnmcollier
Copy link
Member

On airgapped clusters (where access to https://registry.devfile.io might only be available through a proxy), requests via the registry-library fail with:

E0722 21:04:27.064568 1 devfile-handler.go:40] Failed to read from registry https://registry.devfile.io/: Get "https://registry.devfile.io/index/sample": dial tcp 34.198.81.130:443: i/o timeout (Client.Timeout exceeded while awaiting headers)
E0722 21:04:47.088332 1 devfile-handler.go:40] Failed to read from registry https://registry.devfile.io/: Get "https://registry.devfile.io/index/sample": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
E0722 21:05:10.543965 1 devfile-handler.go:40] Failed to read from registry https://registry.devfile.io/: Get "https://registry.devfile.io/index/sample": dial tcp 34.198.81.130:443: i/o timeout (Client.Timeout exceeded while awaiting headers)
E0722 21:05:30.558814 1 devfile-handler.go:40] Failed to read from registry https://registry.devfile.io/: Get "https://registry.devfile.io/index/sample": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
E0722 21:06:07.005139 1 devfile-handler.go:40] Failed to read from registry https://registry.devfile.io/: Get "https://registry.devfile.io/index/sample": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
E0722 21:06:27.017406 1 devfile-handler.go:40] Failed to read from registry https://registry.devfile.io/: Get "https://registry.devfile.io/index/sample": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
E0722 21:09:40.999418 1 devfile-handler.go:40] Failed to read from registry https://registry.devfile.io/: Get "https://registry.devfile.io/index/sample": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
E0722 21:09:57.396735 1 devfile-handler.go:40] Failed to read from registry https://registry.devfile.io/: Get "https://registry.devfile.io/index/sample": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
E0722 21:10:01.024051 1 devfile-handler.go:40] Failed to read from registry https://registry.devfile.io/: Get "https://registry.devfile.io/index/sample": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

The registry library needs to honour any existing proxy configurations that are passed in through the container's environment variable (HTTP_PROXY, HTTPS_PROXY)

/area registry
/kind bug

@openshift-ci openshift-ci bot added area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working labels Jul 27, 2022
@elsony elsony added this to Under consideration in Sprint 222 via automation Jul 27, 2022
@johnmcollier johnmcollier moved this from Under consideration to To do in Sprint 222 Jul 28, 2022
@kim-tsao kim-tsao moved this from To do to In progress in Sprint 222 Aug 3, 2022
@johnmcollier johnmcollier removed this from In progress in Sprint 222 Aug 16, 2022
@johnmcollier johnmcollier added this to Under consideration in Sprint 223 via automation Aug 16, 2022
@johnmcollier johnmcollier moved this from Under consideration to In progress in Sprint 223 Aug 16, 2022
@kim-tsao
Copy link
Contributor

The fix can be entirely contained in the registry library and includes all affected APIs, not just the one that console calls. Once this package is updated, I'll make the dependency change on the console side.

@kim-tsao kim-tsao moved this from In progress to Review in progress in Sprint 223 Aug 31, 2022
@kim-tsao kim-tsao closed this as completed Sep 2, 2022
Sprint 223 automation moved this from Review in progress to Done Sep 2, 2022
kim-tsao added a commit to kim-tsao/registry-support that referenced this issue Sep 19, 2022
kim-tsao added a commit to devfile/registry-support that referenced this issue Sep 19, 2022
…evfile/api#897 (#139)

Signed-off-by: Kim Tsao <ktsao@redhat.com>

Signed-off-by: Kim Tsao <ktsao@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants