Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove plugins from the Devfile schema #333

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Remove plugins from the Devfile schema #333

merged 3 commits into from
Apr 8, 2021

Commits on Apr 6, 2021

  1. Remove plugins from devfile schema by... 

    - adding an option in the jsonschema generator
to allow skipping Plugin union members
- setting this option to true on the Devfile jsonschema annotation.

Signed-off-by: David Festal <dfestal@redhat.com>
    @davidfestal @maysunfaisal
    davidfestal authored and maysunfaisal committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    e808ba1 View commit details
    Browse the repository at this point in the history

  2. Run the fixed generator ... 

    ... to generate devfile schemas without `plugin` components
in both the devfile main body and parent overrides

Signed-off-by: David Festal <dfestal@redhat.com>
    @davidfestal @maysunfaisal
    davidfestal authored and maysunfaisal committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    13683f3 View commit details
    Browse the repository at this point in the history

  3. Update samples and tests for removing plugin 

    Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
    @maysunfaisal
    maysunfaisal committed Apr 6, 2021
    Configuration menu
    Copy the full SHA
    b21137d View commit details
    Browse the repository at this point in the history