add supportURL and provider in metadata, update some description #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangcao77
requested review from
amisevsk,
davidfestal and
sleshchenko
as code owners
Signed-off-by: Stephanie <yangcao@redhat.com>
yangcao77
force-pushed
the
539-add-provider-and-supportURL
branch
from
17549c8
to
087ec3d
Compare
johnmcollier
approved these changes
Sep 3, 2021
| @@ -109,7 +109,8 @@ type GitLikeProjectSource struct { | |||
| // +optional | |||
| CheckoutFrom *CheckoutFrom `json:"checkoutFrom,omitempty"` | |||
|
|
|||
| // The remotes map which should be initialized in the git project. Must have at least one remote configured | |||
| // The remotes map which should be initialized in the git project. | |||
| // Projects must have at least one remote configured while StarterProjects can only have at most one remote configured. | |||
There was a problem hiding this comment.
Should this comment be added to the StarterProject and Project structs as well (over ProjectSource maybe)?
There was a problem hiding this comment.
WDYM? should it already included? since StarterProject/Projects.ProjectSource references GitLikeProjectSource
Signed-off-by: Stephanie <yangcao@redhat.com>
yangcao77
force-pushed
the
539-add-provider-and-supportURL
branch
from
6b5d4d7
to
1536acc
Compare
amisevsk
reviewed
Sep 7, 2021
Signed-off-by: Stephanie <yangcao@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, johnmcollier, yangcao77 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephanie yangcao@redhat.com
What does this PR do?:
This PR adds provider & supportURL as optional fields in devfile metadata, to allow to include provider and support information of stacks/samples
This PR also updated some description to fix #522 and #536
Which issue(s) this PR fixes:
#539
Fixes #522
Fixes #536
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: