Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use nvm to install node and also provides different nodejs versions #24

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Mar 15, 2022

It provides NodeJS 12, NodeJS 14 and 16

16/LTS is the default

…ion (12, 14, 16)

16/lts is the default

Change-Id: Ibc5659a15db63fab238c3364cef9472fd0e7cf08
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benoitf, l0rd

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benoitf benoitf merged commit bf01a50 into devfile:main Mar 15, 2022
@benoitf benoitf deleted the use-nvm branch March 15, 2022 09:12
@nickboldt
Copy link
Contributor

Interesting choice, as Node 12 is EOL in ~ 6weeks ( https://nodejs.org/en/about/releases/ )

This is also not a viable solution for downstream, as we install ONLY from rpms / modules (no curl allowed in Brew).

Ref: eclipse-che/che#20858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants