-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework developers images to make them compatible with Red Hat internal image build tool (aka brew) #20858
Comments
@nickboldt is there something else apart
|
@l0rd see https://issues.redhat.com/browse/CRW-2459 for future work to make it easier to consume CRW dockerfiles outside of brew process. That will give you some insights into what differences there are between public online dockerfiles and Brew internal offline dockerfiles. the other thing we can now do in downstream vs. upstream is to use cachito to manage go, python, and node dependencies. See https://issues.redhat.com/browse/CRW-2444 |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
/remove-lifecycle stale |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
/remove-lifecycle stale |
Is your enhancement related to a problem? Please describe
Che samples devfiles use the universal developer image. The image is built with 2 Dockerfiles (base, universal) that have invalid instructions for Red Hat CI:
RUN curl
instructions are not possible (what if the dependency gets removed from the website? Brew builds are offline, with no direct internet access to fetch tarballs, zips, go/node/pip dependencies, etc.)Describe the solution you'd like
&&
syntax alreadyget-sources.sh
script that pre-downloads assets into the local folder and renames them toasset-*
- see examples in https://github.com/redhat-developer/codeready-workspaces-images/RUN curl
withCOPY asset-*
instructionsARCH="linux_amd64"
,ARCH="x86_64-unknown-linux-musl"
, andARCH="Linux-x86_64"
declarations and compute these fromuname -m
(switching between x86_64 and amd64 as appropriate); this will allow multiarch builds in brewmaintainer
should be an actual person's name + email address (or comma-separated list of more than one), not just a company. See https://github.com/redhat-developer/codeready-workspaces-images/blob/crw-2-rhel-8/codeready-workspaces-idea/Dockerfile#L1126a) provide a transformation script that can remove registry references from
FROM
lines, leaving onlyFROM org/image:tag ...
orFROM org/image@digest ...
6b) if anything is being installed via RPM from EPEL or Fedora, provide .repo files to enable this installation that can be disabled downstream in Brew (not allowed) via the transformation script
The text was updated successfully, but these errors were encountered: